Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: ui/base/ime/input_method_win.h

Issue 1234193002: Simplify InputMethodWin initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_win.h
diff --git a/ui/base/ime/input_method_win.h b/ui/base/ime/input_method_win.h
index 5fdac0856a6782a55815d0b76c73a2372d834630..e1ebb244a2820331c9507e32760a3d2fdd91de98 100644
--- a/ui/base/ime/input_method_win.h
+++ b/ui/base/ime/input_method_win.h
@@ -33,7 +33,6 @@ class UI_BASE_IME_EXPORT InputMethodWin : public InputMethodBase {
void CancelComposition(const TextInputClient* client) override;
void OnInputLocaleChanged() override;
std::string GetInputLocale() override;
- bool IsActive() override;
bool IsCandidatePopupOpen() const override;
protected:
@@ -123,9 +122,6 @@ class UI_BASE_IME_EXPORT InputMethodWin : public InputMethodBase {
// TODO(yukawa, IME): Figure out long-term solution.
bool accept_carriage_return_;
- // Indicates if the current input locale has an IME.
- bool active_;
-
// True when an IME should be allowed to process key events.
bool enabled_;
@@ -136,11 +132,6 @@ class UI_BASE_IME_EXPORT InputMethodWin : public InputMethodBase {
// composition.
HWND composing_window_handle_;
- // Set to false initially. Tracks whether the IME has been initialized with
- // the current input language.
- // crbug.com/508668
- bool default_input_language_initialized_;
-
// Set to true to suppress the next WM_CHAR, when the WM_KEYDOWN gets stopped
// propagation (e.g. triggered an accelerator).
bool suppress_next_char_;

Powered by Google App Engine
This is Rietveld 408576698