Chromium Code Reviews

Unified Diff: chrome/browser/ui/views/certificate_selector.cc

Issue 1234073002: Allow cert-popup for WebView guests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/browser/ui/views/certificate_selector.cc
diff --git a/chrome/browser/ui/views/certificate_selector.cc b/chrome/browser/ui/views/certificate_selector.cc
index d2d5afb7efdd76ad6fb720c4fa4def035e56206c..ead471ba0e7705aca379cb8940497d515a578cc8 100644
--- a/chrome/browser/ui/views/certificate_selector.cc
+++ b/chrome/browser/ui/views/certificate_selector.cc
@@ -87,6 +87,11 @@ CertificateSelector::~CertificateSelector() {
table_->SetModel(nullptr);
}
+// Static.
+bool CertificateSelector::CanShow(content::WebContents* web_contents) {
+ return constrained_window::HasTopLevelDialogManager(web_contents);
jochen (gone - plz use gerrit) 2015/07/15 13:34:01 not sure I understand why you can't inline this he
wjmaclean 2015/07/15 13:59:58 I guess we can. The first time I read through the
+}
+
void CertificateSelector::Show() {
constrained_window::ShowWebModalDialogViews(this, web_contents_);

Powered by Google App Engine