chrome/browser/ui/views/ssl_client_certificate_selector.cc - Issue 1234073002: Allow cert-popup for WebView guests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector.cc

Issue 1234073002: Allow cert-popup for WebView guests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/ssl_client_certificate_selector.cc

diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector.cc b/chrome/browser/ui/views/ssl_client_certificate_selector.cc

index c76ab8e6a30cfabb96dd78cbdfc603c101d2b38b..1963b26447adc99a0216bc5923e50a56309794aa 100644

--- a/chrome/browser/ui/views/ssl_client_certificate_selector.cc

+++ b/chrome/browser/ui/views/ssl_client_certificate_selector.cc

@@ -105,7 +105,7 @@ void ShowSSLClientCertificateSelector(

// TODO(davidben): Move this hook to the WebContentsDelegate and only try to

// show a dialog in Browser's implementation. https://crbug.com/456255

- if (web_modal::PopupManager::FromWebContents(contents) == nullptr)

+ if (!SSLClientCertificateSelector::CanShow(contents))

return;

SSLClientCertificateSelector* selector = new SSLClientCertificateSelector(