Allow cert-popup for WebView guests.

chrome/browser/ui/views/certificate_selector.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/certificate_selector.h"
 
 #include <stddef.h>  // For size_t.
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 69 matching lines @@
       web_contents_(web_contents),
       table_(nullptr),
       view_cert_button_(nullptr) {
   CHECK(web_contents_);
 }
 
 CertificateSelector::~CertificateSelector() {
   table_->SetModel(nullptr);
 }
 
+// Static.
+bool CertificateSelector::CanShow(content::WebContents* web_contents) {
+  return constrained_window::HasTopLevelDialogManager(web_contents);

[jochen (gone - plz use gerrit), 2015/07/15 13:34:01]

not sure I understand why you can't inline this here, but need to duplicate the
logic for mac and views?

[wjmaclean, 2015/07/15 13:59:58]

I guess we can. The first time I read through the code, I missed the fact that
the Mac code can see CertificateSelector. Also, I originally had been trying to
keep the GuestViewBase calls close together in constrained_window_views so that
anyone looking at one would (in all likelihood) see the other.

Done.

+}
+
 void CertificateSelector::Show() {
   constrained_window::ShowWebModalDialogViews(this, web_contents_);
 
   // Select the first row automatically.  This must be done after the dialog has
   // been created.
   table_->Select(0);
 }
 
 void CertificateSelector::InitWithText(scoped_ptr<views::View> text_label) {
   views::GridLayout* const layout = views::GridLayout::CreatePanel(this);
@@ skipping 73 matching lines @@
 void CertificateSelector::OnSelectionChanged() {
   GetDialogClientView()->ok_button()->SetEnabled(GetSelectedCert() != nullptr);
 }
 
 void CertificateSelector::OnDoubleClick() {
   if (GetSelectedCert())
     GetDialogClientView()->AcceptWindow();
 }
 
 }  // namespace chrome