Chromium Code Reviews Chromium Code Reviews
Issue
1234073002:
Allow cert-popup for WebView guests. (Closed)
DescriptionAllow cert-popup for WebView guests.
The SSL cert-selection dialog is currently being suppressed for requests
originating within a WebView guest. This appears to be on account of
1) ShowSSLClientCertificateSelector() not checking to see if the current
WebContents is actually a guest without a WebContentsModalDialogManager,
in which case it should attempt to use the embedder's
WebContentsModalDialogManager,
and possibly also
2) The embedder WebContents in the inline login view will not have a
WebContentsModalDialogManager since it is created via a views::WebView.
This CL partially remedies this by applying the correct check for the
existence of an embedder WebContentsModalDialogManager in the SSL
client certificate dialog code. It does not, however, provide a
WebContentsModalDialogManager for the embedder WebContents in
ProfileChooserView; this will be done in a separate CL (as it will
require some UI design work as well)
Note: applications that want the ability to show the certificate
selector dialog,but are not hosted in a browser tab, have the option
to provide a WebContentsModalDialogManager for the embedder's
WebContents.
BUG=499996
Committed: https://crrev.com/c5e4af9d662bc608ef86d03158ae1c7429bf7436
Cr-Commit-Position: refs/heads/master@{#338957}
Patch Set 1 : #Patch Set 2 : Fix Mac compile. #Patch Set 3 : Add comment. #
Total comments: 4
Patch Set 4 : Inline check for dialog manager. #Patch Set 5 : Add comment clarifying return value for GetTopLevelWebContents(). #Patch Set 6 : Add comment: return value from GetTopLevelWebContents() is always non-null. #Patch Set 7 : Inline Mac check for top-level web-contents. #
Total comments: 7
Patch Set 8 : Improve comments. #
Depends on Patchset: Messages
Total messages: 28 (10 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
