Allow cert-popup for WebView guests.

components/constrained_window/constrained_window_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/constrained_window/constrained_window_views.h"
 
 #include <algorithm>
 
 #include "components/constrained_window/constrained_window_views_client.h"
 #include "components/guest_view/browser/guest_view_base.h"
@@ skipping 112 matching lines @@
   size.SetToMin(max_size);
   UpdateModalDialogPosition(widget, dialog_host, size);
 }
 
 void UpdateWidgetModalDialogPosition(views::Widget* widget,
                                      web_modal::ModalDialogHost* dialog_host) {
   UpdateModalDialogPosition(widget, dialog_host,
                             widget->GetRootView()->GetPreferredSize());
 }
 
+bool HasTopLevelDialogManager(content::WebContents* web_contents) {
+  // For embedded WebContents, use the embedder's WebContents for constrained
+  // window.
+  content::WebContents* top_level_web_contents =
+      guest_view::GuestViewBase::GetTopLevelWebContents(web_contents);

[jochen (gone - plz use gerrit), 2015/07/15 13:34:01]

is the return value guaranteed to be non-NULL? it's not clear to me that
web_contents is always a guest-view?

[wjmaclean, 2015/07/15 13:59:58]

Yes, the return value is guaranteed to be non-null. If the WebContents* passed
in is not a guest, then it is just returned.

+  return web_modal::WebContentsModalDialogManager::FromWebContents(
+             top_level_web_contents) != nullptr;
+}
+
 views::Widget* ShowWebModalDialogViews(
     views::WidgetDelegate* dialog,
     content::WebContents* initiator_web_contents) {
   DCHECK(constrained_window_views_client);
   // For embedded WebContents, use the embedder's WebContents for constrained
   // window.
   content::WebContents* web_contents =
       guest_view::GuestViewBase::GetTopLevelWebContents(initiator_web_contents);
   views::Widget* widget = CreateWebModalDialogViews(dialog, web_contents);
   web_modal::WebContentsModalDialogManager::FromWebContents(web_contents)
@@ skipping 31 matching lines @@
     DCHECK_EQ(parent_view, host->GetHostView());
     ModalDialogHostObserver* dialog_host_observer =
         new WidgetModalDialogHostObserverViews(
             host, widget, kWidgetModalDialogHostObserverViewsKey);
     dialog_host_observer->OnPositionRequiresUpdate();
   }
   return widget;
 }
 
 }  // namespace constrained window