Tighten up DEPS include rules.

Tighten up DEPS include rules.

Allows the following command to return only legitimate
warnings:
  buildtools/checkdeps/checkdeps.py --resolve-dotdot

The remaining warnings consist of:
  - fx_parser_filters.cpp, due to inclusion of
    third_party/zlib_v128/zlib.h, showing the lack
    of a header and some prototypes in that .cpp file.

  - third_party/*, due to inclusion of fx_system.h and
    the like, indicating adulterated libraries that should
    be restored to their pristine state.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/0c96176e6fb4ef37194e7bbff1b04e482e19df89

[Tom Sepez, 2015-07-14 21:18:30]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-07-14 21:18:30]

Lei, for review.  More OCD compulsion on my part.  The warnings, however, are
now pointing to dubious practices.

[Lei Zhang, 2015-07-14 23:02:52]

Commit msg typo: "warngins"

https://codereview.chromium.org/1233583004/diff/1/core/src/fxcodec/DEPS
File core/src/fxcodec/DEPS (right):

https://codereview.chromium.org/1233583004/diff/1/core/src/fxcodec/DEPS#newcode5
core/src/fxcodec/DEPS:5: '+third_party/lcms2-2.6',
nit: alphabetical order

https://codereview.chromium.org/1233583004/diff/1/fpdfsdk/DEPS
File fpdfsdk/DEPS (right):

https://codereview.chromium.org/1233583004/diff/1/fpdfsdk/DEPS#newcode3
fpdfsdk/DEPS:3: '+fpdfsdk',
Do directories have to list themselves in the include rules? I don't see one for
chrome/renderer in chrome/DEPS or chrome/renderer/DEPS, for example.

[Tom Sepez, 2015-07-14 23:12:24]

Fixed commit comment, too.  PTAL.

https://codereview.chromium.org/1233583004/diff/1/core/src/fxcodec/DEPS
File core/src/fxcodec/DEPS (right):

https://codereview.chromium.org/1233583004/diff/1/core/src/fxcodec/DEPS#newcode5
core/src/fxcodec/DEPS:5: '+third_party/lcms2-2.6',
On 2015/07/14 23:02:52, Lei Zhang wrote:
> nit: alphabetical order

Done.

https://codereview.chromium.org/1233583004/diff/1/fpdfsdk/DEPS
File fpdfsdk/DEPS (right):

https://codereview.chromium.org/1233583004/diff/1/fpdfsdk/DEPS#newcode3
fpdfsdk/DEPS:3: '+fpdfsdk',
On 2015/07/14 23:02:52, Lei Zhang wrote:
> Do directories have to list themselves in the include rules? I don't see one
for
> chrome/renderer in chrome/DEPS or chrome/renderer/DEPS, for example.
Good Point.

[Lei Zhang, 2015-07-14 23:13:38]

https://codereview.chromium.org/1233583004/diff/20001/core/DEPS
File core/DEPS (right):

https://codereview.chromium.org/1233583004/diff/20001/core/DEPS#newcode2
core/DEPS:2: '+core',
also remove?

[Tom Sepez, 2015-07-14 23:16:14]

On 2015/07/14 23:13:38, Lei Zhang wrote:
> https://codereview.chromium.org/1233583004/diff/20001/core/DEPS
> File core/DEPS (right):
> 
> https://codereview.chromium.org/1233583004/diff/20001/core/DEPS#newcode2
> core/DEPS:2: '+core',
> also remove?
Done.

[Lei Zhang, 2015-07-14 23:16:52]

lgtm

[Tom Sepez, 2015-07-14 23:17:57]

Committed patchset #3 (id:40001) manually as
0c96176e6fb4ef37194e7bbff1b04e482e19df89 (presubmit successful).