DEPS - Issue 1233583004: Tighten up DEPS include rules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: DEPS

Issue 1233583004: Tighten up DEPS include rules. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: No need for core/DEPS Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 use_relative_paths = True	1 use_relative_paths = True

2	2

3 deps = {	3 deps = {

4 "build/gyp":	4 "build/gyp":

5 "https://chromium.googlesource.com/external/gyp",	5 "https://chromium.googlesource.com/external/gyp",

6	6

7 "buildtools":	7 "buildtools":

8 "https://chromium.googlesource.com/chromium/buildtools.git@46ce8cb60364e9e0b 21a81136c7debdddfd063a8",	8 "https://chromium.googlesource.com/chromium/buildtools.git@46ce8cb60364e9e0b 21a81136c7debdddfd063a8",

9	9

10 "testing/corpus":	10 "testing/corpus":

(...skipping 13 matching lines...) Expand all Loading...
24 }	24 }

25	25

26 deps_os = {	26 deps_os = {

27 "win": {	27 "win": {

28 "v8/third_party/cygwin":	28 "v8/third_party/cygwin":

29 "https://chromium.googlesource.com/chromium/deps/cygwin@c89e446b273697fadf 3a10ff1007a97c0b7de6df",	29 "https://chromium.googlesource.com/chromium/deps/cygwin@c89e446b273697fadf 3a10ff1007a97c0b7de6df",

30 },	30 },

31 }	31 }

32	32

33 include_rules = [	33 include_rules = [

34 '+core/include',

35 '+fpdfsdk/include',

36 '+public',	34 '+public',

37 '+testing',	35 '+testing',

38 '+third_party/base',	36 '+third_party/base',

	37 '+v8',

39 ]	38 ]

40	39

41 hooks = [	40 hooks = [

42 {	41 {

43 # A change to a .gyp, .gypi, or to GYP itself should run the generator.	42 # A change to a .gyp, .gypi, or to GYP itself should run the generator.

44 'name': 'gyp',	43 'name': 'gyp',

45 'pattern': '.',	44 'pattern': '.',

46 'action': ['python', 'build/gyp_pdfium'],	45 'action': ['python', 'build/gyp_pdfium'],

47 },	46 },

48 ]	47 ]

OLD	NEW

« no previous file with comments | « no previous file | core/src/fxcodec/DEPS » ('j') | no next file with comments »