fpdfsdk/DEPS - Issue 1233583004: Tighten up DEPS include rules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fpdfsdk/DEPS

Issue 1233583004: Tighten up DEPS include rules. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 '+core/include',

	3 '+fpdfsdk',
	Lei Zhang 2015/07/14 23:02:52 Do directories have to list themselves in the incl Do directories have to list themselves in the include rules? I don't see one for chrome/renderer in chrome/DEPS or chrome/renderer/DEPS, for example. Tom Sepez 2015/07/14 23:12:24 Good Point. Show quoted text On 2015/07/14 23:02:52, Lei Zhang wrote: > Do directories have to list themselves in the include rules? I don't see one for > chrome/renderer in chrome/DEPS or chrome/renderer/DEPS, for example. Good Point.
	4 '+javascript',

	5 ]

OLD	NEW