Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3420)

Unified Diff: build/android/gyp/javac.py

Issue 1233453010: GN: Fix support errorprone and java_binary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn12
Patch Set: Add errorprone target only for OS=android Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/BUILD.gn ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/javac.py
diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py
index 4a9b9cdac58b3c1d51facf378fcfc96f9cd12d6c..dafe5dff0ab9a9f767c3105641283fa30a84cdaf 100755
--- a/build/android/gyp/javac.py
+++ b/build/android/gyp/javac.py
@@ -87,13 +87,15 @@ def DoJavac(
# Chromium only allows UTF8 source files. Being explicit avoids
# javac pulling a default encoding from the user's environment.
'-encoding', 'UTF-8',
- '-source', '1.7',
- '-target', '1.7',
'-classpath', ':'.join(classpath),
'-d', classes_dir]
if bootclasspath:
- javac_args.extend(['-bootclasspath', ':'.join(bootclasspath)])
+ javac_args.extend([
+ '-bootclasspath', ':'.join(bootclasspath),
+ '-source', '1.7',
+ '-target', '1.7',
+ ])
if chromium_code:
# TODO(aurimas): re-enable '-Xlint:deprecation' checks once they are fixed.
« no previous file with comments | « build/android/BUILD.gn ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698