Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 123303003: Move all the packet parsing logic into QuicDispatcher from the (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Move all the packet parsing logic into QuicDispatcher from the QuicServer / QuicDispatcher / QuicTimeWaitListManager. Merge internal change: 58413216 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -359 lines) Patch
M net/quic/quic_connection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_framer.h View 3 chunks +5 lines, -8 lines 0 comments Download
M net/quic/quic_framer.cc View 3 chunks +6 lines, -22 lines 0 comments Download
M net/quic/quic_framer_test.cc View 4 chunks +29 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator_test.cc View 11 chunks +11 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +31 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 6 chunks +153 lines, -21 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 4 chunks +41 lines, -7 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +0 lines, -8 lines 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +1 line, -16 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 3 chunks +5 lines, -19 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 5 chunks +5 lines, -40 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 4 chunks +14 lines, -102 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 8 chunks +11 lines, -94 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 11 months ago (2014-01-02 19:52:47 UTC) #1
Ryan Hamilton
6 years, 11 months ago (2014-01-02 20:07:47 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698