Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: net/tools/quic/quic_server_test.cc

Issue 123303003: Move all the packet parsing logic into QuicDispatcher from the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_server.cc ('k') | net/tools/quic/quic_time_wait_list_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_server_test.cc
diff --git a/net/tools/quic/quic_server_test.cc b/net/tools/quic/quic_server_test.cc
index 7d24edc28bb12737c871b7bcf44c1951dbdcc019..23efeb60cbc24a661e6736f6a45846a80a838370 100644
--- a/net/tools/quic/quic_server_test.cc
+++ b/net/tools/quic/quic_server_test.cc
@@ -23,11 +23,9 @@ class QuicServerDispatchPacketTest : public ::testing::Test {
: crypto_config_("blah", QuicRandom::GetInstance()),
dispatcher_(config_, crypto_config_, 1234, &eps_) {}
-
- void MaybeDispatchPacket(const QuicEncryptedPacket& packet) {
+ void DispatchPacket(const QuicEncryptedPacket& packet) {
IPEndPoint client_addr, server_addr;
- QuicServer::MaybeDispatchPacket(&dispatcher_, packet,
- client_addr, server_addr);
+ dispatcher_.ProcessPacket(server_addr, client_addr, packet);
}
protected:
@@ -37,19 +35,7 @@ class QuicServerDispatchPacketTest : public ::testing::Test {
MockQuicDispatcher dispatcher_;
};
-TEST_F(QuicServerDispatchPacketTest, DoNotDispatchPacketWithoutGUID) {
- // Packet too short to be considered valid.
- unsigned char invalid_packet[] = { 0x00 };
- QuicEncryptedPacket encrypted_invalid_packet(
- QuicUtils::AsChars(invalid_packet), arraysize(invalid_packet), false);
-
- // We expect the invalid packet to be dropped, and ProcessPacket should never
- // be called.
- EXPECT_CALL(dispatcher_, ProcessPacket(_, _, _, _, _)).Times(0);
- MaybeDispatchPacket(encrypted_invalid_packet);
-}
-
-TEST_F(QuicServerDispatchPacketTest, DispatchValidPacket) {
+TEST_F(QuicServerDispatchPacketTest, DispatchPacket) {
unsigned char valid_packet[] = {
// public flags (8 byte guid)
0x3C,
@@ -64,8 +50,8 @@ TEST_F(QuicServerDispatchPacketTest, DispatchValidPacket) {
QuicEncryptedPacket encrypted_valid_packet(QuicUtils::AsChars(valid_packet),
arraysize(valid_packet), false);
- EXPECT_CALL(dispatcher_, ProcessPacket(_, _, _, _, _)).Times(1);
- MaybeDispatchPacket(encrypted_valid_packet);
+ EXPECT_CALL(dispatcher_, ProcessPacket(_, _, _)).Times(1);
+ DispatchPacket(encrypted_valid_packet);
}
} // namespace
« no previous file with comments | « net/tools/quic/quic_server.cc ('k') | net/tools/quic/quic_time_wait_list_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698