Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: net/quic/quic_framer.h

Issue 123303003: Move all the packet parsing logic into QuicDispatcher from the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_framer.h
diff --git a/net/quic/quic_framer.h b/net/quic/quic_framer.h
index 4e6815961def8f15f2fd7496637952b5791a8afb..47cbb96ad1f9042ae75fd8f8689e366a22398a75 100644
--- a/net/quic/quic_framer.h
+++ b/net/quic/quic_framer.h
@@ -82,6 +82,11 @@ class NET_EXPORT_PRIVATE QuicFramerVisitorInterface {
// before it has been processed.
virtual void OnRevivedPacket() = 0;
+ // Called when the public header has been parsed, but has not been
+ // authenticated. If it returns false, framing for this packet will cease.
+ virtual bool OnUnauthenticatedPublicHeader(
+ const QuicPacketPublicHeader& header) = 0;
+
// Called when the unauthenticated portion of the header has been parsed.
// If OnUnauthenticatedHeader returns false, framing for this packet will
// cease.
@@ -167,9 +172,6 @@ class NET_EXPORT_PRIVATE QuicFramer {
// Returns true if |version| is a supported protocol version.
bool IsSupportedVersion(const QuicVersion version) const;
- // Returns true if the version flag is set in the public flags.
- static bool HasVersionFlag(const QuicEncryptedPacket& packet);
-
// Set callbacks to be called from the framer. A visitor must be set, or
// else the framer will likely crash. It is acceptable for the visitor
// to do nothing. If this is called multiple times, only the last visitor
@@ -339,11 +341,6 @@ class NET_EXPORT_PRIVATE QuicFramer {
const std::string& detailed_error() { return detailed_error_; }
- // Read the full 8 byte guid from a packet header.
- // Return true on success, else false.
- static bool ReadGuidFromPacket(const QuicEncryptedPacket& packet,
- QuicGuid* guid);
-
// The minimum sequence number length required to represent |sequence_number|.
static QuicSequenceNumberLength GetMinSequenceNumberLength(
QuicPacketSequenceNumber sequence_number);
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698