Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 12330082: Merge 143355 (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 143355 > [chromium] Fix races in double-tap zoom minimum scale policy > https://bugs.webkit.org/show_bug.cgi?id=110183 > > Reviewed by Adam Barth. > > Double-tap zoom on Android is supposed to return to minimum scale > if no pinch zoom occurred since the last double-tap. Because both > pinch zoom and the result of double-tap zoom gets passed in from CC > via applyScrollAndScale, this logic was brittle and prone to races > depending on when the animation update was received. This patch > keeps track of what the target double-tap scale is to make it more > robust. > > I also fixed double-tap zoom test mocking to exercise the entire > page scale animation flow (our previous way of testing was hiding the > raciness), and added a new test case in DivAutoZoomMultipleParamsTest. > > * src/WebViewImpl.cpp: > (WebKit::WebViewImpl::WebViewImpl): > (WebKit::WebViewImpl::startPageScaleAnimation): > (WebKit): > (WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting): > (WebKit::WebViewImpl::computeScaleAndScrollForHitRect): > (WebKit::WebViewImpl::animateZoomAroundPoint): > (WebKit::WebViewImpl::didCommitLoad): > (WebKit::WebViewImpl::applyScrollAndScale): > * src/WebViewImpl.h: > (WebViewImpl): > (WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting): > (WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting): > (WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting): > (WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting): > * tests/WebFrameTest.cpp: > TBR=aelias@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -41 lines) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +144 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.h View 3 chunks +14 lines, -5 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 7 chunks +41 lines, -27 lines 0 comments Download
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 8 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-22 20:35:05 UTC) #1
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-22 20:35:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143778.

Powered by Google App Engine
This is Rietveld 408576698