OLD | NEW |
| 1 2013-02-19 Alexandre Elias <aelias@chromium.org> |
| 2 |
| 3 [chromium] Fix races in double-tap zoom minimum scale policy |
| 4 https://bugs.webkit.org/show_bug.cgi?id=110183 |
| 5 |
| 6 Reviewed by Adam Barth. |
| 7 |
| 8 Double-tap zoom on Android is supposed to return to minimum scale |
| 9 if no pinch zoom occurred since the last double-tap. Because both |
| 10 pinch zoom and the result of double-tap zoom gets passed in from CC |
| 11 via applyScrollAndScale, this logic was brittle and prone to races |
| 12 depending on when the animation update was received. This patch |
| 13 keeps track of what the target double-tap scale is to make it more |
| 14 robust. |
| 15 |
| 16 I also fixed double-tap zoom test mocking to exercise the entire |
| 17 page scale animation flow (our previous way of testing was hiding the |
| 18 raciness), and added a new test case in DivAutoZoomMultipleParamsTest. |
| 19 |
| 20 * src/WebViewImpl.cpp: |
| 21 (WebKit::WebViewImpl::WebViewImpl): |
| 22 (WebKit::WebViewImpl::startPageScaleAnimation): |
| 23 (WebKit): |
| 24 (WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting): |
| 25 (WebKit::WebViewImpl::computeScaleAndScrollForHitRect): |
| 26 (WebKit::WebViewImpl::animateZoomAroundPoint): |
| 27 (WebKit::WebViewImpl::didCommitLoad): |
| 28 (WebKit::WebViewImpl::applyScrollAndScale): |
| 29 * src/WebViewImpl.h: |
| 30 (WebViewImpl): |
| 31 (WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting): |
| 32 (WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting): |
| 33 (WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting): |
| 34 (WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting): |
| 35 * tests/WebFrameTest.cpp: |
| 36 |
| 37 2013-02-19 Joshua Bell <jsbell@chromium.org> |
| 38 |
| 39 IndexedDB: additional checks on LevelDB decoding |
| 40 https://bugs.webkit.org/show_bug.cgi?id=109711 |
| 41 |
| 42 Reviewed by Tony Chang. |
| 43 |
| 44 * tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures
. |
| 45 |
| 46 2013-02-19 Jochen Eisinger <jochen@chromium.org> |
| 47 |
| 48 [chromium] fix ScrollAnimatorNoneTest after r143295 |
| 49 https://bugs.webkit.org/show_bug.cgi?id=110189 |
| 50 |
| 51 Reviewed by Nico Weber. |
| 52 |
| 53 * tests/ScrollAnimatorNoneTest.cpp: |
| 54 (MockScrollableArea): |
| 55 |
| 56 2013-02-18 Simon Fraser <simon.fraser@apple.com> |
| 57 |
| 58 Clean up the boolean argument to visibleContentRect |
| 59 https://bugs.webkit.org/show_bug.cgi?id=110167 |
| 60 |
| 61 Reviewed by Simon Fraser. |
| 62 |
| 63 Replace the boolean argument to visibleContentRect() with |
| 64 an enum. |
| 65 |
| 66 * src/ChromeClientImpl.cpp: |
| 67 (WebKit::ChromeClientImpl::popupOpened): |
| 68 |
| 69 2013-02-18 Sheriff Bot <webkit.review.bot@gmail.com> |
| 70 |
| 71 Unreviewed. Rolled Chromium DEPS to r183105. Requested by |
| 72 thakis_ via sheriffbot. |
| 73 |
| 74 * DEPS: |
| 75 |
| 76 2013-02-18 Nico Weber <thakis@chromium.org> |
| 77 |
| 78 [chromium] Remove ahem_path from WebKit.gyp |
| 79 https://bugs.webkit.org/show_bug.cgi?id=110111 |
| 80 |
| 81 Reviewed by Jochen Eisinger. |
| 82 |
| 83 It's only used in DumpRenderTree.gyp, and that file defines its own |
| 84 copy of this variable. |
| 85 |
| 86 * WebKit.gyp: |
| 87 |
| 88 2013-02-18 Laszlo Gombos <l.gombos@samsung.com> |
| 89 |
| 90 Move ENABLE macros for WebCore out from Platform.h |
| 91 https://bugs.webkit.org/show_bug.cgi?id=105735 |
| 92 |
| 93 Move the chromium specific WebCore ENABLE macro definitions |
| 94 from Platform.h to features.gypi. |
| 95 |
| 96 Reviewed by Darin Adler and Benjamin Poulain. |
| 97 |
| 98 * features.gypi: Set ENABLE_SUBPIXEL_LAYOUT to 1. |
| 99 |
| 100 2013-02-15 Alec Flett <alecflett@chromium.org> |
| 101 |
| 102 IndexedDB: Stub out SharedBuffer version of get() |
| 103 https://bugs.webkit.org/show_bug.cgi?id=108993 |
| 104 |
| 105 Reviewed by Darin Fisher. |
| 106 |
| 107 All asynchronous get()-like calls go through WebIDBCallbacks, |
| 108 so this includes both get() and cursor callbacks. |
| 109 |
| 110 * public/WebIDBCallbacks.h: |
| 111 (WebKit::WebIDBCallbacks::onSuccess): |
| 112 (WebKit::WebIDBCallbacks::onSuccessWithPrefetch): |
| 113 |
| 114 2013-02-15 Alec Flett <alecflett@chromium.org> |
| 115 |
| 116 IndexedDB: fix chromium windows bustage |
| 117 https://bugs.webkit.org/show_bug.cgi?id=109970 |
| 118 |
| 119 Unreviewed build fix for Chromium Windows. |
| 120 |
| 121 * tests/IDBDatabaseBackendTest.cpp: |
| 122 |
| 123 2013-02-15 Alec Flett <alecflett@chromium.org> |
| 124 |
| 125 IndexedDB: Implement SharedBuffer version of put() |
| 126 https://bugs.webkit.org/show_bug.cgi?id=109092 |
| 127 |
| 128 Reviewed by Adam Barth. |
| 129 |
| 130 Implement SharedBuffer/WebData version of |
| 131 IDBDatabaseBackendInterface::put, and put |
| 132 temporary scaffolding in until chrome is ready. |
| 133 |
| 134 * src/IDBDatabaseBackendProxy.cpp: |
| 135 (WebKit::IDBDatabaseBackendProxy::put): |
| 136 * src/IDBDatabaseBackendProxy.h: |
| 137 (IDBDatabaseBackendProxy): |
| 138 * src/WebIDBDatabaseImpl.cpp: |
| 139 (WebKit::WebIDBDatabaseImpl::put): |
| 140 (WebKit): |
| 141 * src/WebIDBDatabaseImpl.h: |
| 142 (WebIDBDatabaseImpl): |
| 143 * tests/IDBDatabaseBackendTest.cpp: |
| 144 |
1 2013-02-15 Alexandre Elias <aelias@chromium.org> | 145 2013-02-15 Alexandre Elias <aelias@chromium.org> |
2 | 146 |
3 [chromium] WebInputEventBuilders should not reverse page scale | 147 [chromium] WebInputEventBuilders should not reverse page scale |
4 https://bugs.webkit.org/show_bug.cgi?id=109901 | 148 https://bugs.webkit.org/show_bug.cgi?id=109901 |
5 | 149 |
6 Reviewed by James Robinson. | 150 Reviewed by James Robinson. |
7 | 151 |
8 Though in theory logical that if WebInputEvent -> PlatformEvent | 152 Though in theory logical that if WebInputEvent -> PlatformEvent |
9 conversions divide by page scale, then the reverse builders should | 153 conversions divide by page scale, then the reverse builders should |
10 multiply, in reality the only user of the reverse builders is | 154 multiply, in reality the only user of the reverse builders is |
(...skipping 13842 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
13853 | 13997 |
13854 [Chromium-Win] Implement LocaleWin::dateFormat | 13998 [Chromium-Win] Implement LocaleWin::dateFormat |
13855 https://bugs.webkit.org/show_bug.cgi?id=98117 | 13999 https://bugs.webkit.org/show_bug.cgi?id=98117 |
13856 | 14000 |
13857 Reviewed by Kentaro Hara. | 14001 Reviewed by Kentaro Hara. |
13858 | 14002 |
13859 * tests/LocaleWinTest.cpp: | 14003 * tests/LocaleWinTest.cpp: |
13860 (TEST_F): Add tests for LocaleWin::dateFormat. | 14004 (TEST_F): Add tests for LocaleWin::dateFormat. |
13861 | 14005 |
13862 == Rolled over to ChangeLog-2012-10-02 == | 14006 == Rolled over to ChangeLog-2012-10-02 == |
OLD | NEW |