Crash tests when BrowserTestBase::SetUp is not called

Crash tests when BrowserTestBase::SetUp is not called

This is being done to prevent false positive test results that occur
when subclasses of BrowserTestBase override SetUp but fail to call the
superclass version.

This technique (keep track of whether SetUp was called and crash in the
destructor if it wasn't) was already used in ContentBrowserTest. This CL
moves usage of that pattern up to BrowserTestBase.

BUG=510649
Committed: https://crrev.com/632247ab88b66a6fe424a0a38d22b7623775468c
Cr-Commit-Position: refs/heads/master@{#341135}

[pval...(no longer on Chromium), 2015-07-13 22:34:22]

The CQ bit was checked by pvalenzuela@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-13 22:37:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232973002/1

[commit-bot: I haz the power, 2015-07-13 23:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 23:25:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[pval...(no longer on Chromium), 2015-07-16 00:39:54]

The CQ bit was checked by pvalenzuela@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-16 00:40:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232973002/20001

[commit-bot: I haz the power, 2015-07-16 00:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 00:46:54]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[pval...(no longer on Chromium), 2015-07-20 22:12:09]

Patchset #1 (id:1) has been deleted

[pval...(no longer on Chromium), 2015-07-20 22:24:18]

Patchset #1 (id:20001) has been deleted

[pval...(no longer on Chromium), 2015-07-20 22:32:05]

pvalenzuela@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[pval...(no longer on Chromium), 2015-07-20 22:32:05]

phajdan.jr@,

I'm sending this CL out now to get feedback, but we're not quite ready to commit
just yet. I am working with the affected test owners (see the blocking bugs for
https://code.google.com/p/chromium/issues/detail?id=510649) to fix or disable
their tests.

[Paweł Hajdan Jr., 2015-07-20 23:52:10]

Looks fine to me. Please let me know when it's ready for the final review, and
thanks for the cleanup!

[pval...(no longer on Chromium), 2015-07-23 22:32:59]

The CQ bit was checked by pvalenzuela@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-23 22:34:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1232973002/40001

[commit-bot: I haz the power, 2015-07-23 23:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-23 23:34:28]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pval...(no longer on Chromium), 2015-07-28 22:25:44]

The CQ bit was checked by pvalenzuela@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-28 22:27:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1232973002/40001

[commit-bot: I haz the power, 2015-07-28 23:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 23:40:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pval...(no longer on Chromium), 2015-07-29 18:55:14]

The CQ bit was checked by pvalenzuela@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-29 18:55:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1232973002/40001

[commit-bot: I haz the power, 2015-07-29 19:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 19:27:42]

Dry run: This issue passed the CQ dry run.

[pval...(no longer on Chromium), 2015-07-29 22:26:18]

Paweł, this is ready for the final review!

[Paweł Hajdan Jr., 2015-07-30 12:16:12]

LGTM, thanks!

[pval...(no longer on Chromium), 2015-07-30 16:11:34]

The CQ bit was checked by pvalenzuela@chromium.org

[commit-bot: I haz the power, 2015-07-30 16:11:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1232973002/40001

[commit-bot: I haz the power, 2015-07-30 16:49:28]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2015-07-30 16:50:18]

Patchset 1 (id:??) landed as
https://crrev.com/632247ab88b66a6fe424a0a38d22b7623775468c
Cr-Commit-Position: refs/heads/master@{#341135}