Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: content/public/test/browser_test_base.h

Issue 1232973002: Crash tests when BrowserTestBase::SetUp is not called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/test/browser_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/browser_test_base.h
diff --git a/content/public/test/browser_test_base.h b/content/public/test/browser_test_base.h
index e323d8878176f3b5e891173f2ede349b9477b780..69b73c74b211e3e7507f1aba95ac63b9d05099af 100644
--- a/content/public/test/browser_test_base.h
+++ b/content/public/test/browser_test_base.h
@@ -152,6 +152,11 @@ class BrowserTestBase : public testing::Test {
// When true, do compositing with the software backend instead of using GL.
bool use_software_compositing_;
+ // Whether SetUp was called. This value is checked in the destructor of this
+ // class to ensure that SetUp was called. If it's not called, the test will
+ // not run and report a false positive result.
+ bool set_up_called_;
+
#if defined(OS_POSIX)
bool handle_sigterm_;
#endif
« no previous file with comments | « no previous file | content/public/test/browser_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698