Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: content/public/test/content_browser_test.cc

Issue 1232973002: Crash tests when BrowserTestBase::SetUp is not called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/content_browser_test.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/content_browser_test.cc
diff --git a/content/public/test/content_browser_test.cc b/content/public/test/content_browser_test.cc
index a6802124f9c59e70e1382c5d7bdb95fd851a364a..6bcea4c64f5e2ba99e35b61a8610d21d9efe60cd 100644
--- a/content/public/test/content_browser_test.cc
+++ b/content/public/test/content_browser_test.cc
@@ -35,8 +35,7 @@
namespace content {
-ContentBrowserTest::ContentBrowserTest()
- : setup_called_(false) {
+ContentBrowserTest::ContentBrowserTest() {
#if defined(OS_MACOSX)
// See comment in InProcessBrowserTest::InProcessBrowserTest().
base::FilePath content_shell_path;
@@ -56,8 +55,6 @@ ContentBrowserTest::ContentBrowserTest()
}
ContentBrowserTest::~ContentBrowserTest() {
- CHECK(setup_called_) << "Overridden SetUp() did not call parent "
- "implementation, so test not run.";
}
void ContentBrowserTest::SetUp() {
@@ -97,8 +94,6 @@ void ContentBrowserTest::SetUp() {
ui::InitializeInputMethodForTesting();
#endif
- setup_called_ = true;
-
BrowserTestBase::SetUp();
}
« no previous file with comments | « content/public/test/content_browser_test.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698