Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: net/url_request/url_request_job.h

Issue 12328072: Remove some calls to URLRequestContext::network_delegate(). (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Make network_delegate_ a protected member of URLRequestJob. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job.h
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index 4d985f8a19d9a5b8e06fe200eefd3d2c5eba8037..5b66b260539e534593742fa1b2b6ac2a93ce5115 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -305,6 +305,9 @@ class NET_EXPORT URLRequestJob : public base::RefCounted<URLRequestJob>,
// request was released by DetachRequest().
URLRequest* request_;
+ // The network delegate to use with this request, if any.
+ NetworkDelegate* network_delegate_;
mmenke 2013/03/07 15:45:39 Let's just expose this via an accessor instead. S
tedv 2013/03/07 15:58:32 Makes sense; will change that. On 2013/03/07 15:4
+
private:
// When data filtering is enabled, this function is used to read data
// for the filter. Returns true if raw data was read. Returns false if
@@ -379,8 +382,6 @@ class NET_EXPORT URLRequestJob : public base::RefCounted<URLRequestJob>,
GURL deferred_redirect_url_;
int deferred_redirect_status_code_;
- NetworkDelegate* network_delegate_;
-
base::WeakPtrFactory<URLRequestJob> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(URLRequestJob);

Powered by Google App Engine
This is Rietveld 408576698