Remove some calls to URLRequestContext::network_delegate().

net/url_request/url_request_job_factory_impl_unittest.cc

Index: net/url_request/url_request_job_factory_impl_unittest.cc
diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc
index 5f0e16c36e54f1a461c9867ea2d5734d008d1067..e03668a934c6a60226463db6c07da841e18d0c5a 100644
--- a/net/url_request/url_request_job_factory_impl_unittest.cc
+++ b/net/url_request/url_request_job_factory_impl_unittest.cc
@@ -60,7 +60,7 @@ class DummyProtocolHandler : public URLRequestJobFactory::ProtocolHandler {
 TEST(URLRequestJobFactoryTest, NoProtocolHandler) {
   TestDelegate delegate;
   TestURLRequestContext request_context;
-  TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);
+  TestURLRequest request(GURL("foo://bar"), &delegate, &request_context, NULL);
   request.Start();
 
   MessageLoop::current()->Run();
@@ -74,7 +74,7 @@ TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
   TestURLRequestContext request_context;
   request_context.set_job_factory(&job_factory);
   job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);
-  TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);
+  TestURLRequest request(GURL("foo://bar"), &delegate, &request_context, NULL);

[mmenke, 2013/03/07 15:45:39]

The TestURLRequestDelegate does have some very basic sanity checking that we
lose by using NULL instead.  Think this is fine in this CL, but it is something
to be aware of in future CLs.

[tedv, 2013/03/07 15:58:32]

My understanding of the code is that TestURLRequestContext gets constructed with
a NULL NetworkDelegate* by default, so I don't believe this loses any sanity
checking.  Unless I missed something in TestURLRequestContext::Init()?

There are other uses of TestURLRequestContexts that use non-NULL network
delegates which I've identified in other pending CLs though.

On 2013/03/07 15:45:39, mmenke wrote:

[mmenke, 2013/03/07 16:05:58]

It gets constructed, but if it's not passed to the URLRequest on construction
(You're passing NULL here), the request won't use it.

   request.Start();
 
   MessageLoop::current()->Run();