Remove some calls to URLRequestContext::network_delegate().

net/url_request/url_request_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 287 matching lines @@
 
   // Total number of bytes read from network (or cache) and typically handed
   // to filter to process.  Used to histogram compression ratios, and error
   // recovery scenarios in filters.
   int64 filter_input_byte_count() const { return filter_input_byte_count_; }
 
   // The request that initiated this job. This value MAY BE NULL if the
   // request was released by DetachRequest().
   URLRequest* request_;
 
+  // The network delegate to use with this request, if any.
+  NetworkDelegate* network_delegate_;

[mmenke, 2013/03/07 15:45:39]

Let's just expose this via an accessor instead.  Subclasses don't need to be
able to modify the pointer.

[tedv, 2013/03/07 15:58:32]

Makes sense; will change that.

On 2013/03/07 15:45:39, mmenke wrote:

+
  private:
   // When data filtering is enabled, this function is used to read data
   // for the filter.  Returns true if raw data was read.  Returns false if
   // an error occurred (or we are waiting for IO to complete).
   bool ReadRawDataForFilter(int *bytes_read);
 
   // Invokes ReadRawData and records bytes read if the read completes
   // synchronously.
   bool ReadRawDataHelper(IOBuffer* buf, int buf_size, int* bytes_read);
 
@@ skipping 54 matching lines @@
   // OnResponseStarted callback and potentially redirect callbacks as well.
   bool has_handled_response_;
 
   // Expected content size
   int64 expected_content_size_;
 
   // Set when a redirect is deferred.
   GURL deferred_redirect_url_;
   int deferred_redirect_status_code_;
 
-  NetworkDelegate* network_delegate_;
-
   base::WeakPtrFactory<URLRequestJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_JOB_H_