Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1232803002: Debugger: refactor reloc info. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: refactor reloc info. - split relocation info for debug break slots for - calls (with call arguments count as data) - construct calls - normal slots - renamed DEBUG_BREAK into DEBUGGER_STATEMENT - removed unused IC state for Debug stubs R=ulan@chromium.org BUG=v8:4269 LOG=N Committed: https://crrev.com/198c75f6cd3b7641ae422dacf837049f95c37e2f Cr-Commit-Position: refs/heads/master@{#29603}

Patch Set 1 #

Patch Set 2 : fix mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -106 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm64/debug-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 7 chunks +26 lines, -10 lines 0 comments Download
M src/assembler.cc View 9 chunks +17 lines, -31 lines 0 comments Download
M src/builtins.h View 1 chunk +5 lines, -9 lines 0 comments Download
M src/debug.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/debug.cc View 4 chunks +23 lines, -19 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
5 years, 5 months ago (2015-07-13 08:31:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232803002/1
5 years, 5 months ago (2015-07-13 09:38:46 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/2646)
5 years, 5 months ago (2015-07-13 09:47:32 UTC) #5
ulan
lgtm if mips is fixed.
5 years, 5 months ago (2015-07-13 10:50:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232803002/20001
5 years, 5 months ago (2015-07-13 11:28:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 12:32:13 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 12:32:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/198c75f6cd3b7641ae422dacf837049f95c37e2f
Cr-Commit-Position: refs/heads/master@{#29603}

Powered by Google App Engine
This is Rietveld 408576698