Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: src/debug.h

Issue 1232803002: Debugger: refactor reloc info. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix mips Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.h ('k') | src/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.h
diff --git a/src/debug.h b/src/debug.h
index bde56c2b7cc99b5e052ac8b043cba906cd0d4ba6..4f90f3a01935eac5229785d9250c242c60274e95 100644
--- a/src/debug.h
+++ b/src/debug.h
@@ -80,10 +80,10 @@ class BreakLocation {
bool IsDebugBreak() const;
inline bool IsExit() const { return RelocInfo::IsJSReturn(rmode_); }
inline bool IsCall() const {
- return IsDebugBreakSlot() && RelocInfo::DebugBreakIsCall(data_);
+ return RelocInfo::IsDebugBreakSlotAtCall(rmode_);
}
inline bool IsConstructCall() const {
- return IsDebugBreakSlot() && RelocInfo::DebugBreakIsConstructCall(data_);
+ return RelocInfo::IsDebugBreakSlotAtConstructCall(rmode_);
}
inline int CallArgumentsCount() const {
DCHECK(IsCall());
@@ -153,11 +153,12 @@ class BreakLocation {
inline int statement_position() const { return statement_position_; }
private:
+ static int GetModeMask(BreakLocatorType type);
+
bool RinfoDone() const;
void RinfoNext();
Handle<DebugInfo> debug_info_;
- BreakLocatorType type_;
RelocIterator reloc_iterator_;
RelocIterator reloc_iterator_original_;
int break_index_;
« no previous file with comments | « src/builtins.h ('k') | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698