Proxy new WebData-based onSuccess() calls.

Proxy new WebData-based onSuccess() calls.

BUG=156247
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184052

[alecflett, 2013-02-20 23:18:23]

jsbell / tsepez: review?

This is pretty straight forward, though I had to do some nasty casting... as
you'll see the nasty casting is only in the 'Old' case - so it will be removed
when the webkit side lands.

The nasty casting/conversion may also result in a slight performance drop
(because now we have one extra buffer copy in cursor prefetching) until I land
the webkit change, which will ultimately result in a net improvement.

[Tom Sepez, 2013-02-20 23:35:11]

Messages LGTM.

[jsbell, 2013-02-20 23:52:08]

lgtm with nits and questions

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
File content/browser/in_process_webkit/indexed_db_callbacks.cc (right):

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
content/browser/in_process_webkit/indexed_db_callbacks.cc:10: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebSerializedScriptValue.h"
Odd to see this line added. Temporary?

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
File content/browser/in_process_webkit/indexed_db_callbacks.h (right):

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
content/browser/in_process_webkit/indexed_db_callbacks.h:114: virtual void
onSuccess(const WebKit::WebIDBKey& key,
While you're in the guts here... what do you think about removing this overload
and using the onSuccess(cursor, key, primaryKey, value) overload instead?
Redundant data but simplify the plumbing?

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:51: using
WebKit::WebSerializedScriptValue;
This can be removed now, right?

https://codereview.chromium.org/12326023/diff/1/content/common/indexed_db/pro...
File content/common/indexed_db/proxy_webidbcursor_impl.cc (right):

https://codereview.chromium.org/12326023/diff/1/content/common/indexed_db/pro...
content/common/indexed_db/proxy_webidbcursor_impl.cc:134: const
std::vector<WebKit::WebData>& values) {
Add a using WebKit::WebData declaration up top to avoid having to use namespace
prefix here and below.

[alecflett, 2013-02-21 00:14:16]

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
File content/browser/in_process_webkit/indexed_db_callbacks.cc (right):

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
content/browser/in_process_webkit/indexed_db_callbacks.cc:10: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebSerializedScriptValue.h"
On 2013/02/20 23:52:08, jsbell wrote:
> Odd to see this line added. Temporary?

I believe this is because we're removing references to it on the webkit side.

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
File content/browser/in_process_webkit/indexed_db_callbacks.h (right):

https://codereview.chromium.org/12326023/diff/1/content/browser/in_process_we...
content/browser/in_process_webkit/indexed_db_callbacks.h:114: virtual void
onSuccess(const WebKit::WebIDBKey& key,
On 2013/02/20 23:52:08, jsbell wrote:
> While you're in the guts here... what do you think about removing this
overload
> and using the onSuccess(cursor, key, primaryKey, value) overload instead?
> Redundant data but simplify the plumbing?

Talked about this briefly - we'll tackle this if/when we switch to cursor_ids

https://codereview.chromium.org/12326023/diff/1/content/common/indexed_db/pro...
File content/common/indexed_db/proxy_webidbcursor_impl.cc (right):

https://codereview.chromium.org/12326023/diff/1/content/common/indexed_db/pro...
content/common/indexed_db/proxy_webidbcursor_impl.cc:134: const
std::vector<WebKit::WebData>& values) {
On 2013/02/20 23:52:08, jsbell wrote:
> Add a using WebKit::WebData declaration up top to avoid having to use
namespace
> prefix here and below.

Done.

[commit-bot: I haz the power, 2013-02-21 00:15:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12326023/8001

[commit-bot: I haz the power, 2013-02-21 00:41:07]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-21 19:32:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12326023/14001

[commit-bot: I haz the power, 2013-02-21 20:00:43]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-21 20:07:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12326023/14001

[commit-bot: I haz the power, 2013-02-21 20:20:05]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-21 20:20:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12326023/14004

[commit-bot: I haz the power, 2013-02-21 20:46:47]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-21 21:05:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12326023/2012

[commit-bot: I haz the power, 2013-02-21 21:31:59]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-21 23:49:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12326023/13

[commit-bot: I haz the power, 2013-02-22 03:00:45]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-22 03:05:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12326023/13

[commit-bot: I haz the power, 2013-02-22 06:24:35]

Change committed as 184052