Proxy new WebData-based onSuccess() calls.

content/browser/in_process_webkit/indexed_db_callbacks.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_IN_PROCESS_WEBKIT_INDEXED_DB_CALLBACKS_H_
 #define CONTENT_BROWSER_IN_PROCESS_WEBKIT_INDEXED_DB_CALLBACKS_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "content/browser/in_process_webkit/indexed_db_dispatcher_host.h"
 #include "googleurl/src/gurl.h"
+#include "third_party/WebKit/Source/Platform/chromium/public/WebData.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBCallbacks.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBCursor.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBDatabase.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBDatabaseError.h"
 
 namespace content {
 
 class IndexedDBCallbacksBase : public WebKit::WebIDBCallbacks {
  public:
@@ skipping 77 matching lines @@
                          const WebKit::WebSerializedScriptValue& value);
   virtual void onSuccess(const WebKit::WebIDBKey& key,
                          const WebKit::WebIDBKey& primaryKey,
                          const WebKit::WebSerializedScriptValue& value);
   virtual void onSuccess(const WebKit::WebSerializedScriptValue& value);
   virtual void onSuccessWithPrefetch(
       const WebKit::WebVector<WebKit::WebIDBKey>& keys,
       const WebKit::WebVector<WebKit::WebIDBKey>& primaryKeys,
       const WebKit::WebVector<WebKit::WebSerializedScriptValue>& values);
 
+  virtual void onSuccess(WebKit::WebIDBCursor* idb_object,
+                         const WebKit::WebIDBKey& key,
+                         const WebKit::WebIDBKey& primaryKey,
+                         const WebKit::WebData& value);
+  virtual void onSuccess(const WebKit::WebIDBKey& key,

[jsbell, 2013/02/20 23:52:08]

While you're in the guts here... what do you think about removing this overload
and using the onSuccess(cursor, key, primaryKey, value) overload instead?
Redundant data but simplify the plumbing?

[alecflett, 2013/02/21 00:14:16]

Talked about this briefly - we'll tackle this if/when we switch to cursor_ids

+                         const WebKit::WebIDBKey& primaryKey,
+                         const WebKit::WebData& value);
+  virtual void onSuccess(const WebKit::WebData& value);
+  virtual void onSuccessWithPrefetch(
+      const WebKit::WebVector<WebKit::WebIDBKey>& keys,
+      const WebKit::WebVector<WebKit::WebIDBKey>& primaryKeys,
+      const WebKit::WebVector<WebKit::WebData>& values);
+
  private:
   // The id of the cursor this callback concerns, or -1 if the cursor
   // does not exist yet.
   int32 ipc_cursor_id_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(IndexedDBCallbacks);
 };
 
 // WebIDBKey is implemented in WebKit as opposed to being an interface Chromium
 // implements.  Thus we pass a const ___& version and thus we need this
@@ skipping 52 matching lines @@
                          const WebKit::WebIDBKey& key,
                          const WebKit::WebIDBKeyPath& keyPath);
   virtual void onSuccess(long long value);
   virtual void onSuccess();
   virtual void onSuccess(const WebKit::WebIDBKey& value);
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(IndexedDBCallbacks);
 };
 
+// WebData is implemented in WebKit as opposed to being an interface
+// Chromium implements.  Thus we pass a const ___& version and thus we
+// need this specialization.
+template <>
+class IndexedDBCallbacks<WebKit::WebData>
+    : public IndexedDBCallbacksBase {
+ public:
+  IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
+                     int32 ipc_thread_id,
+                     int32 ipc_response_id)
+      : IndexedDBCallbacksBase(dispatcher_host, ipc_thread_id,
+                               ipc_response_id) { }
+
+  virtual void onSuccess(const WebKit::WebData& value);
+  virtual void onSuccess(const WebKit::WebData& value,
+                         const WebKit::WebIDBKey& key,
+                         const WebKit::WebIDBKeyPath& keyPath);
+  virtual void onSuccess(long long value);
+  virtual void onSuccess();
+  virtual void onSuccess(const WebKit::WebIDBKey& value);
+
+ private:
+  DISALLOW_IMPLICIT_CONSTRUCTORS(IndexedDBCallbacks);
+};
+
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_IN_PROCESS_WEBKIT_INDEXED_DB_CALLBACKS_H_