Using the new Network*Handlers in networkingPrivate Extension API.

chromeos/network/network_state.h

Index: chromeos/network/network_state.h
diff --git a/chromeos/network/network_state.h b/chromeos/network/network_state.h
index 3f64a07ae6b86bbf5388e8ff7f70ef282ecc8e5c..75d8d30a178e8e559ad4e6f5068845fe4cda2019 100644
--- a/chromeos/network/network_state.h
+++ b/chromeos/network/network_state.h
@@ -5,8 +5,13 @@
 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_
 #define CHROMEOS_NETWORK_NETWORK_STATE_H_
 
+#include "base/memory/scoped_ptr.h"

[stevenjb, 2013/03/05 17:59:18]

Not needed

[pneubeck (no reviews), 2013/03/07 15:53:02]

Done.

 #include "chromeos/network/managed_state.h"
 
+namespace base {
+class DictionaryValue;
+}
+
 namespace chromeos {
 
 // Simple class to provide network state information about a network service.
@@ -40,6 +45,10 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
   bool IsConnectedState() const;
   bool IsConnectingState() const;
 
+  // Fills |dictionary| with the state properties. This is the inverse function
+  // to PropertyChanged.

[gauravsh, 2013/03/05 21:04:56]

How often do you anticipate this being used? Since we have accessors for all the
properties, does this helper needs to be a method in the class?

[pneubeck (no reviews), 2013/03/07 15:53:02]

By having this function in network_state.cc, we reduce the number of places with
references to Shill state constants and it's easier to keep the two directions
of translation in sync.

With this change, the only places that use these constants are the ONC
translator and NetworkState. I'd prefer to not add another such dependency.

On 2013/03/05 21:04:56, gauravsh wrote:

+  void FillDictionary(base::DictionaryValue* dictionary) const;

[gauravsh, 2013/03/05 21:04:56]

I'd prefer a less generic name - GetPropertyDictionary(), for example.

[pneubeck (no reviews), 2013/03/07 15:53:02]

Dictionary is already encoded in the type. Chose GetProperties.

On 2013/03/05 21:04:56, gauravsh wrote:

+
   // Helpers (used e.g. when a state is cached)
   static bool StateIsConnected(const std::string& connection_state);
   static bool StateIsConnecting(const std::string& connection_state);