Using the new Network*Handlers in networkingPrivate Extension API.

chromeos/network/network_state.cc

Index: chromeos/network/network_state.cc
diff --git a/chromeos/network/network_state.cc b/chromeos/network/network_state.cc
index bbe698aac0628b07074e8cc4d3782e780a9fbcc5..06c9097b9f4aeafa7ec2c6f3cbfbb86caadaa4c7 100644
--- a/chromeos/network/network_state.cc
+++ b/chromeos/network/network_state.cc
@@ -51,6 +51,29 @@ bool NetworkState::IsConnectingState() const {
   return StateIsConnecting(connection_state_);
 }
 
+void NetworkState::FillDictionary(base::DictionaryValue* dictionary) const {

[stevenjb, 2013/03/05 17:59:18]

nit: let's put this (and the header definition) just below PropertyChanged(),
and comment in the header that changing one should change the other.

[pneubeck (no reviews), 2013/03/07 15:53:02]

Done.

+  dictionary->SetStringWithoutPathExpansion(flimflam::kNameProperty, name());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kTypeProperty, type());
+  dictionary->SetIntegerWithoutPathExpansion(flimflam::kSignalStrengthProperty,
+                                            signal_strength());

[gauravsh, 2013/03/05 21:04:56]

NIT: indent off?

[pneubeck (no reviews), 2013/03/07 15:53:02]

Done.

+  dictionary->SetStringWithoutPathExpansion(flimflam::kStateProperty,
+                                           connection_state());

[gauravsh, 2013/03/05 21:04:56]

NIT: indent off? (and for the lines below as well).

[pneubeck (no reviews), 2013/03/07 15:53:02]

Done.

+  dictionary->SetStringWithoutPathExpansion(flimflam::kErrorProperty,
+                                           error());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kActivationStateProperty,
+                                           activation_state());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kRoamingStateProperty,
+                                           roaming());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kSecurityProperty,
+                                           security());
+  dictionary->SetStringWithoutPathExpansion(
+      flimflam::kNetworkTechnologyProperty,
+      technology());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kDeviceProperty,
+                                            device_path());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kGuidProperty, guid());
+}
+
 // static
 bool NetworkState::StateIsConnected(const std::string& connection_state) {
   return (connection_state == flimflam::kStateReady ||