Using the new Network*Handlers in networkingPrivate Extension API.

chromeos/network/network_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_
 #define CHROMEOS_NETWORK_NETWORK_STATE_H_
 
+#include "base/memory/scoped_ptr.h"

[stevenjb, 2013/03/05 17:59:18]

Not needed

[pneubeck (no reviews), 2013/03/07 15:53:02]

Done.

 #include "chromeos/network/managed_state.h"
 
+namespace base {
+class DictionaryValue;
+}
+
 namespace chromeos {
 
 // Simple class to provide network state information about a network service.
 // This class should always be passed as a const* and should never be held
 // on to. Store network_state->path() (defined in ManagedState) instead and
 // call NetworkStateHandler::GetNetworkState(path) to retrieve the state for
 // the network.
 class CHROMEOS_EXPORT NetworkState : public ManagedState {
  public:
   explicit NetworkState(const std::string& path);
@@ skipping 13 matching lines @@
   // Wireless property accessors
   int signal_strength() const { return signal_strength_; }
   // Cellular property accessors
   const std::string& technology() const { return technology_; }
   const std::string& activation_state() const { return activation_state_; }
   const std::string& roaming() const { return roaming_; }
 
   bool IsConnectedState() const;
   bool IsConnectingState() const;
 
+  // Fills |dictionary| with the state properties. This is the inverse function
+  // to PropertyChanged.

[gauravsh, 2013/03/05 21:04:56]

How often do you anticipate this being used? Since we have accessors for all the
properties, does this helper needs to be a method in the class?

[pneubeck (no reviews), 2013/03/07 15:53:02]

By having this function in network_state.cc, we reduce the number of places with
references to Shill state constants and it's easier to keep the two directions
of translation in sync.

With this change, the only places that use these constants are the ONC
translator and NetworkState. I'd prefer to not add another such dependency.

On 2013/03/05 21:04:56, gauravsh wrote:

+  void FillDictionary(base::DictionaryValue* dictionary) const;

[gauravsh, 2013/03/05 21:04:56]

I'd prefer a less generic name - GetPropertyDictionary(), for example.

[pneubeck (no reviews), 2013/03/07 15:53:02]

Dictionary is already encoded in the type. Chose GetProperties.

On 2013/03/05 21:04:56, gauravsh wrote:

+
   // Helpers (used e.g. when a state is cached)
   static bool StateIsConnected(const std::string& connection_state);
   static bool StateIsConnecting(const std::string& connection_state);
 
  private:
   friend class NetworkStateHandler;
   friend class NetworkChangeNotifierChromeosUpdateTest;
 
   // Called by NetworkStateHandler when the ip config changes.
   void set_ip_address(const std::string& ip_address) {
@@ skipping 13 matching lines @@
   std::string technology_;
   std::string activation_state_;
   std::string roaming_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkState);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_NETWORK_STATE_H_