Using the new Network*Handlers in networkingPrivate Extension API.

chromeos/network/network_state.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_state.h"
 
 #include "base/values.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
@@ skipping 33 matching lines @@
 }
 
 bool NetworkState::IsConnectedState() const {
   return StateIsConnected(connection_state_);
 }
 
 bool NetworkState::IsConnectingState() const {
   return StateIsConnecting(connection_state_);
 }
 
+void NetworkState::FillDictionary(base::DictionaryValue* dictionary) const {

[stevenjb, 2013/03/05 17:59:18]

nit: let's put this (and the header definition) just below PropertyChanged(),
and comment in the header that changing one should change the other.

[pneubeck (no reviews), 2013/03/07 15:53:02]

Done.

+  dictionary->SetStringWithoutPathExpansion(flimflam::kNameProperty, name());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kTypeProperty, type());
+  dictionary->SetIntegerWithoutPathExpansion(flimflam::kSignalStrengthProperty,
+                                            signal_strength());

[gauravsh, 2013/03/05 21:04:56]

NIT: indent off?

[pneubeck (no reviews), 2013/03/07 15:53:02]

Done.

+  dictionary->SetStringWithoutPathExpansion(flimflam::kStateProperty,
+                                           connection_state());

[gauravsh, 2013/03/05 21:04:56]

NIT: indent off? (and for the lines below as well).

[pneubeck (no reviews), 2013/03/07 15:53:02]

Done.

+  dictionary->SetStringWithoutPathExpansion(flimflam::kErrorProperty,
+                                           error());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kActivationStateProperty,
+                                           activation_state());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kRoamingStateProperty,
+                                           roaming());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kSecurityProperty,
+                                           security());
+  dictionary->SetStringWithoutPathExpansion(
+      flimflam::kNetworkTechnologyProperty,
+      technology());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kDeviceProperty,
+                                            device_path());
+  dictionary->SetStringWithoutPathExpansion(flimflam::kGuidProperty, guid());
+}
+
 // static
 bool NetworkState::StateIsConnected(const std::string& connection_state) {
   return (connection_state == flimflam::kStateReady ||
           connection_state == flimflam::kStateOnline ||
           connection_state == flimflam::kStatePortal);
 }
 
 // static
 bool NetworkState::StateIsConnecting(const std::string& connection_state) {
   return (connection_state == flimflam::kStateAssociation ||
           connection_state == flimflam::kStateConfiguration ||
           connection_state == flimflam::kStateCarrier);
 }
 
 }  // namespace chromeos