Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Unified Diff: sandbox/win/src/ipc_unittest.cc

Issue 1231673002: Sandbox: remove raw handles from SharedMemIPCServer::ServerControl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sandbox/win/src/sharedmem_ipc_server.h » ('j') | sandbox/win/src/sharedmem_ipc_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/ipc_unittest.cc
diff --git a/sandbox/win/src/ipc_unittest.cc b/sandbox/win/src/ipc_unittest.cc
index ddad9b4283bc72b6d48ad71dad2b486e3931c305..ec98aecd802934c1bb6628abfb39f851ebe6e049 100644
--- a/sandbox/win/src/ipc_unittest.cc
+++ b/sandbox/win/src/ipc_unittest.cc
@@ -616,10 +616,10 @@ TEST(IPCTest, SharedMemServerTests) {
UnitTestIPCDispatcher dispatcher;
// Since we are directly calling InvokeCallback, most of this structure
// can be set to NULL.
- sandbox::SharedMemIPCServer::ServerControl srv_control = {
- NULL, NULL, kIPCChannelSize, NULL,
- reinterpret_cast<char*>(client_control),
- NULL, &dispatcher, {0} };
+ sandbox::SharedMemIPCServer::ServerControl srv_control = {};
+ srv_control.channel_size = kIPCChannelSize;
+ srv_control.shared_base = reinterpret_cast<char*>(client_control);
+ srv_control.dispatcher = &dispatcher;
sandbox::CrossCallReturn call_return = {0};
EXPECT_TRUE(SharedMemIPCServer::InvokeCallback(&srv_control, buff,
« no previous file with comments | « no previous file | sandbox/win/src/sharedmem_ipc_server.h » ('j') | sandbox/win/src/sharedmem_ipc_server.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698