Issue 12314007: Support connecting to HTTPS URL's through a proxy

Issue 12314007: Support connecting to HTTPS URL's through a proxy (Closed)

Created:
7 years, 10 months ago by Søren Gjesse

Modified:
7 years, 10 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support connecting to HTTPS URL's through a proxy The communication from the client to the proxy server is not secure. R=ajohnsen@google.com BUG=http://code.google.com/p/dart/issues/detail?id=5454 Committed: https://code.google.com/p/dart/source/detail?r=18759

Patch Set 1 #

Patch Set 2 : Added test and fixed implementation #

Total comments: 6

Patch Set 3 : Addressed review comments #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -27 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/standalone/io/http_proxy_test.dart	View	1 2	7 chunks	+47 lines, -26 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Can you add a test for this, so we are sure it works here, and ...

7 years, 10 months ago (2013-02-20 08:47:16 UTC) #2

Søren Gjesse

On 2013/02/20 08:47:16, Anders Johnsen wrote: > Can you add a test for this, so ...

7 years, 10 months ago (2013-02-20 14:18:49 UTC) #3

Anders Johnsen

LGTM! https://codereview.chromium.org/12314007/diff/1002/tests/standalone/io/http_proxy_test.dart File tests/standalone/io/http_proxy_test.dart (right): https://codereview.chromium.org/12314007/diff/1002/tests/standalone/io/http_proxy_test.dart#newcode199 tests/standalone/io/http_proxy_test.dart:199: ? "https://localhost:${secureServer.port}/$i" localhost vs 127.0.0.1? https://codereview.chromium.org/12314007/diff/1002/tests/standalone/io/http_proxy_test.dart#newcode202 tests/standalone/io/http_proxy_test.dart:202: HttpClientConnection ...

7 years, 10 months ago (2013-02-20 14:24:20 UTC) #4

Søren Gjesse

https://codereview.chromium.org/12314007/diff/1002/tests/standalone/io/http_proxy_test.dart File tests/standalone/io/http_proxy_test.dart (right): https://codereview.chromium.org/12314007/diff/1002/tests/standalone/io/http_proxy_test.dart#newcode199 tests/standalone/io/http_proxy_test.dart:199: ? "https://localhost:${secureServer.port}/$i" On 2013/02/20 14:24:20, Anders Johnsen wrote: > ...

7 years, 10 months ago (2013-02-20 14:35:08 UTC) #5

Søren Gjesse

7 years, 10 months ago (2013-02-20 14:37:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r18759 (presubmit successful).

Expand Messages | Collapse Messages