sdk/lib/io/http_impl.dart - Issue 12314007: Support connecting to HTTPS URL's through a proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/http_impl.dart

Issue 12314007: Support connecting to HTTPS URL's through a proxy (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/http_impl.dart

diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart

index 4a8d266a2fb10cbc5186ae5000db40eb0b87cb18..ede39a2418e518c3fc6b1ea5dba2681fca5107ac 100644

--- a/sdk/lib/io/http_impl.dart

+++ b/sdk/lib/io/http_impl.dart

@@ -2026,7 +2026,7 @@ class _HttpClient implements HttpClient {

}

if (socketConnections == null || socketConnections.isEmpty) {

- Socket socket = secure ?

+ Socket socket = secure && proxy.isDirect ?

new SecureSocket(connectHost,

connectPort,

sendClientCertificate: _sendClientCertificate,

« no previous file with comments | « no previous file | tests/standalone/io/http_proxy_test.dart » ('j') | no next file with comments »