Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

Issue 12310103: Small cleanups in RegExp to avoid generating lots of code just because there is a try/catch in our … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('k') | sdk/lib/collection/collections.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (revision 19035)
+++ sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (working copy)
@@ -176,36 +176,32 @@
String temporaryId(HInstruction instruction) {
String prefix;
HType type = instruction.instructionType;
- if (!type.isPrimitive()) {
- prefix = 'U';
+ if (type == HType.MUTABLE_ARRAY) {
+ prefix = 'm';
+ } else if (type == HType.READABLE_ARRAY) {
+ prefix = 'a';
+ } else if (type == HType.EXTENDABLE_ARRAY) {
+ prefix = 'e';
+ } else if (type == HType.BOOLEAN) {
+ prefix = 'b';
+ } else if (type == HType.INTEGER) {
+ prefix = 'i';
+ } else if (type == HType.DOUBLE) {
+ prefix = 'd';
+ } else if (type == HType.NUMBER) {
+ prefix = 'n';
+ } else if (type == HType.STRING) {
+ prefix = 's';
+ } else if (type == HType.UNKNOWN) {
+ prefix = 'v';
+ } else if (type == HType.CONFLICTING) {
+ prefix = 'c';
+ } else if (type == HType.INDEXABLE_PRIMITIVE) {
+ prefix = 'r';
+ } else if (type == HType.NULL) {
+ prefix = 'u';
} else {
- if (type == HType.MUTABLE_ARRAY) {
- prefix = 'm';
- } else if (type == HType.READABLE_ARRAY) {
- prefix = 'a';
- } else if (type == HType.EXTENDABLE_ARRAY) {
- prefix = 'e';
- } else if (type == HType.BOOLEAN) {
- prefix = 'b';
- } else if (type == HType.INTEGER) {
- prefix = 'i';
- } else if (type == HType.DOUBLE) {
- prefix = 'd';
- } else if (type == HType.NUMBER) {
- prefix = 'n';
- } else if (type == HType.STRING) {
- prefix = 's';
- } else if (type == HType.UNKNOWN) {
- prefix = 'v';
- } else if (type == HType.CONFLICTING) {
- prefix = 'c';
- } else if (type == HType.INDEXABLE_PRIMITIVE) {
- prefix = 'r';
- } else if (type == HType.NULL) {
- prefix = 'u';
- } else {
- prefix = 'x';
- }
+ prefix = 'U';
}
return "$prefix${instruction.id}";
}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('k') | sdk/lib/collection/collections.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698