Small cleanups in RegExp to avoid generating lots of code just because there is a try/catch in our …

sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library tracer;
 
 import 'dart:io';
 import 'ssa.dart';
 import '../js_backend/js_backend.dart';
 import '../dart2jslib.dart';
@@ skipping 158 matching lines @@
   JavaScriptItemCompilationContext context;
   HBasicBlock currentBlock;
 
   HInstructionStringifier(this.context, this.currentBlock);
 
   visit(HInstruction node) => node.accept(this);
 
   String temporaryId(HInstruction instruction) {
     String prefix;
     HType type = instruction.instructionType;
-    if (!type.isPrimitive()) {
+    if (type == HType.MUTABLE_ARRAY) {
+      prefix = 'm';
+    } else if (type == HType.READABLE_ARRAY) {
+      prefix = 'a';
+    } else if (type == HType.EXTENDABLE_ARRAY) {
+      prefix = 'e';
+    } else if (type == HType.BOOLEAN) {
+      prefix = 'b';
+    } else if (type == HType.INTEGER) {
+      prefix = 'i';
+    } else if (type == HType.DOUBLE) {
+      prefix = 'd';
+    } else if (type == HType.NUMBER) {
+      prefix = 'n';
+    } else if (type == HType.STRING) {
+      prefix = 's';
+    } else if (type == HType.UNKNOWN) {
+      prefix = 'v';
+    } else if (type == HType.CONFLICTING) {
+      prefix = 'c';
+    } else if (type == HType.INDEXABLE_PRIMITIVE) {
+      prefix = 'r';
+    } else if (type == HType.NULL) {
+      prefix = 'u';
+    } else {
       prefix = 'U';
-    } else {
-      if (type == HType.MUTABLE_ARRAY) {
-        prefix = 'm';
-      } else if (type == HType.READABLE_ARRAY) {
-        prefix = 'a';
-      } else if (type == HType.EXTENDABLE_ARRAY) {
-        prefix = 'e';
-      } else if (type == HType.BOOLEAN) {
-        prefix = 'b';
-      } else if (type == HType.INTEGER) {
-        prefix = 'i';
-      } else if (type == HType.DOUBLE) {
-        prefix = 'd';
-      } else if (type == HType.NUMBER) {
-        prefix = 'n';
-      } else if (type == HType.STRING) {
-        prefix = 's';
-      } else if (type == HType.UNKNOWN) {
-        prefix = 'v';
-      } else if (type == HType.CONFLICTING) {
-        prefix = 'c';
-      } else if (type == HType.INDEXABLE_PRIMITIVE) {
-        prefix = 'r';
-      } else if (type == HType.NULL) {
-        prefix = 'u';
-      } else {
-        prefix = 'x';
-      }
     }
     return "$prefix${instruction.id}";
   }
 
   String visitBailoutTarget(HBailoutTarget node) {
     StringBuffer envBuffer = new StringBuffer();
     List<HInstruction> inputs = node.inputs;
     for (int i = 0; i < inputs.length; i++) {
       envBuffer.write(" ${temporaryId(inputs[i])}");
     }
@@ skipping 335 matching lines @@
 
   String visitTypeConversion(HTypeConversion node) {
     return "TypeConversion: ${temporaryId(node.checkedInput)} to "
       "${node.instructionType}";
   }
 
   String visitRangeConversion(HRangeConversion node) {
     return "RangeConversion: ${node.checkedInput}";
   }
 }