sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 12310103: Small cleanups in RegExp to avoid generating lots of code just because there is a try/catch in our …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 12310103: Small cleanups in RegExp to avoid generating lots of code just because there is a try/catch in our … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/string_helper.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 19035)

+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)

@@ -138,8 +138,16 @@

// If we can replace [instruction] with [replacement], then

// [replacement]'s type can be narrowed.

- replacement.instructionType = replacement.instructionType.intersection(

+ HType newType = replacement.instructionType.intersection(

instruction.instructionType, compiler);

+ if (!newType.isConflicting()) {

+ // [HType.intersection] may give up when doing the

+ // intersection of two types is too complicated, and return

+ // [HType.CONFLICTING]. We do not want instructions to have

+ // [HType.CONFLICTING], so we only update the type if the

+ // intersection did not give up.

+ replacement.instructionType = newType;

+ }

// If the replacement instruction does not know its

// source element, use the source element of the