net/cert/cert_database_mac.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_database_mac.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_database_mac.cc

diff --git a/net/cert/cert_database_mac.cc b/net/cert/cert_database_mac.cc

index 9427be316d22f251c2f9daa33412ded0076f5714..eeca511fc5c7bc6753df5bba6c03776d54e92d31 100644

--- a/net/cert/cert_database_mac.cc

+++ b/net/cert/cert_database_mac.cc

@@ -159,7 +159,7 @@ int CertDatabase::AddUserCert(X509Certificate* cert) {

switch (err) {

case noErr:

CertDatabase::NotifyObserversOfCertAdded(cert);

- // Fall through.

+ FALLTHROUGH_INTENDED;

case errSecDuplicateItem:

return OK;

default: