net/base/registry_controlled_domains/registry_controlled_domain.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/registry_controlled_domains/registry_controlled_domain.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/registry_controlled_domains/registry_controlled_domain.cc

diff --git a/net/base/registry_controlled_domains/registry_controlled_domain.cc b/net/base/registry_controlled_domains/registry_controlled_domain.cc

index 56d5ed9d6a176864f6f4beb9af06d9d9cfafd485..f05c16b36aec4dbc097560f6cd8b93182cb7c6b4 100644

--- a/net/base/registry_controlled_domains/registry_controlled_domain.cc

+++ b/net/base/registry_controlled_domains/registry_controlled_domain.cc

@@ -53,7 +53,11 @@

#include "url/gurl.h"

#include "url/url_parse.h"

+// gperf intentionally uses fallthroughs.

+#pragma clang diagnostic push

+#pragma clang diagnostic ignored "-Wimplicit-fallthrough"

#include "effective_tld_names.cc"

+#pragma clang diagnostic pop

namespace net {

namespace registry_controlled_domains {

« no previous file with comments | « net/base/gzip_header.cc ('k') | net/cert/cert_database_mac.cc » ('j') | no next file with comments »