net/cert/cert_status_flags.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_status_flags.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_status_flags.cc

diff --git a/net/cert/cert_status_flags.cc b/net/cert/cert_status_flags.cc

index 06ecddc04bf5a99487b3a3d1ee9084b6c3f95fdb..5a27176c345f1750e00a3ec4f6f5fbc1ebdf3bb2 100644

--- a/net/cert/cert_status_flags.cc

+++ b/net/cert/cert_status_flags.cc

@@ -36,7 +36,7 @@ CertStatus MapNetErrorToCertStatus(int error) {

// We should not use ERR_CERT_CONTAINS_ERRORS in new code.

case ERR_CERT_CONTAINS_ERRORS:

NOTREACHED();

- // Falls through.

+ FALLTHROUGH_INTENDED;

case ERR_CERT_INVALID:

return CERT_STATUS_INVALID;

case ERR_CERT_WEAK_SIGNATURE_ALGORITHM:

« no previous file with comments | « net/cert/cert_database_mac.cc ('k') | net/dns/dns_config_service_posix.cc » ('j') | no next file with comments »