base/third_party/dmg_fp/dtoa_wrapper.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/third_party/dmg_fp/dtoa_wrapper.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/third_party/dmg_fp/dtoa_wrapper.cc

diff --git a/base/third_party/dmg_fp/dtoa_wrapper.cc b/base/third_party/dmg_fp/dtoa_wrapper.cc

index c314c59d87430688d777a45ea029bb0e2162227f..f16263e2a6aa47f1784f89d388df507a039669fb 100644

--- a/base/third_party/dmg_fp/dtoa_wrapper.cc

+++ b/base/third_party/dmg_fp/dtoa_wrapper.cc

@@ -43,4 +43,11 @@ inline static void FREE_DTOA_LOCK(size_t n) {

lock->Release();

}

+// dtoa.cc intentionally uses fallthroughs.

+#pragma clang diagnostic push

+#pragma clang diagnostic ignored "-Wimplicit-fallthrough"

#include "base/third_party/dmg_fp/dtoa.cc"

+#pragma clang diagnostic pop

« no previous file with comments | « base/process/process_metrics_mac.cc ('k') | base/third_party/icu/icu_utf.cc » ('j') | no next file with comments »