Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: base/third_party/dmg_fp/dtoa_wrapper.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/process/process_metrics_mac.cc ('k') | base/third_party/icu/icu_utf.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // The purpose of this file is to supply the macro definintions necessary 5 // The purpose of this file is to supply the macro definintions necessary
6 // to make third_party/dmg_fp/dtoa.cc threadsafe. 6 // to make third_party/dmg_fp/dtoa.cc threadsafe.
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/synchronization/lock.h" 9 #include "base/synchronization/lock.h"
10 10
(...skipping 25 matching lines...) Expand all
36 base::Lock* lock = n == 0 ? dtoa_lock_0.Pointer() : dtoa_lock_1.Pointer(); 36 base::Lock* lock = n == 0 ? dtoa_lock_0.Pointer() : dtoa_lock_1.Pointer();
37 lock->Acquire(); 37 lock->Acquire();
38 } 38 }
39 39
40 inline static void FREE_DTOA_LOCK(size_t n) { 40 inline static void FREE_DTOA_LOCK(size_t n) {
41 DCHECK(n < 2); 41 DCHECK(n < 2);
42 base::Lock* lock = n == 0 ? dtoa_lock_0.Pointer() : dtoa_lock_1.Pointer(); 42 base::Lock* lock = n == 0 ? dtoa_lock_0.Pointer() : dtoa_lock_1.Pointer();
43 lock->Release(); 43 lock->Release();
44 } 44 }
45 45
46
47 // dtoa.cc intentionally uses fallthroughs.
48 #pragma clang diagnostic push
49 #pragma clang diagnostic ignored "-Wimplicit-fallthrough"
50
46 #include "base/third_party/dmg_fp/dtoa.cc" 51 #include "base/third_party/dmg_fp/dtoa.cc"
52
53 #pragma clang diagnostic pop
OLDNEW
« no previous file with comments | « base/process/process_metrics_mac.cc ('k') | base/third_party/icu/icu_utf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698