base/process/process_metrics_mac.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/process_metrics_mac.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process/process_metrics_mac.cc

diff --git a/base/process/process_metrics_mac.cc b/base/process/process_metrics_mac.cc

index 048735ed36b6a068f35f249e111e9917c585911d..8e96661f8a14eb6c6f8f15ea8fdabb0281386562 100644

--- a/base/process/process_metrics_mac.cc

+++ b/base/process/process_metrics_mac.cc

@@ -166,7 +166,7 @@ bool ProcessMetrics::GetMemoryBytes(size_t* private_bytes,

break;

case SM_COW:

private_pages_count += info.private_pages_resident;

- // Fall through

+ FALLTHROUGH_INTENDED;

case SM_SHARED:

if (seen_objects.count(info.obj_id) == 0) {

// Only count the first reference to this region.

« no previous file with comments | « base/json/json_parser.cc ('k') | base/third_party/dmg_fp/dtoa_wrapper.cc » ('j') | no next file with comments »