base/json/json_parser.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_parser.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_parser.cc

diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc

index f1f43337c408663f68bde52856616a07b259638a..bc64036a67e5015aa79eef9e51c3dec6218b66e8 100644

--- a/base/json/json_parser.cc

+++ b/base/json/json_parser.cc

@@ -405,7 +405,7 @@ void JSONParser::EatWhitespaceAndComments() {

// Don't increment line_number_ twice for "\r\n".

if (!(*pos_ == '\n' && pos_ > start_pos_ && *(pos_ - 1) == '\r'))

++line_number_;

- // Fall through.

+ FALLTHROUGH_INTENDED;

case ' ':

case '\t':

NextChar();

« no previous file with comments | « base/compiler_specific.h ('k') | base/process/process_metrics_mac.cc » ('j') | no next file with comments »