Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230933005: Add a finch flag to disable ContextualSearch selection expansion. (Closed)

Created:
5 years, 5 months ago by aurimas (slooooooooow)
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a finch flag to disable ContextualSearch selection expansion. BUG=396738 TBR=dtrainor@chromium.org Committed: https://crrev.com/f984db32fb2f461b550bc92ed8b1f644139b466f Cr-Commit-Position: refs/heads/master@{#338419}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add JavaDoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
aurimas (slooooooooow)
PTAL
5 years, 5 months ago (2015-07-10 23:37:30 UTC) #2
pedro (no code reviews)
lgtm https://codereview.chromium.org/1230933005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java File chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java (right): https://codereview.chromium.org/1230933005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java#newcode256 chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java:256: public static boolean isSelectionExpansionDisabled() { Nit: JavaDoc
5 years, 5 months ago (2015-07-10 23:47:57 UTC) #3
aurimas (slooooooooow)
https://codereview.chromium.org/1230933005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java File chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java (right): https://codereview.chromium.org/1230933005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java#newcode256 chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java:256: public static boolean isSelectionExpansionDisabled() { On 2015/07/10 at 23:47:57, ...
5 years, 5 months ago (2015-07-11 00:10:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230933005/20001
5 years, 5 months ago (2015-07-11 00:10:34 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-11 00:10:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230933005/20001
5 years, 5 months ago (2015-07-11 00:33:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-11 01:15:57 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 01:17:03 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f984db32fb2f461b550bc92ed8b1f644139b466f
Cr-Commit-Position: refs/heads/master@{#338419}

Powered by Google App Engine
This is Rietveld 408576698