Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1720)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java

Issue 1230933005: Add a finch flag to disable ContextualSearch selection expansion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add JavaDoc Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
index 21c2a4eaa893d616a0d1583bb03a47d6ce4d034c..61a451b53f45ff4fa92e18d5892226885c58c0dd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
@@ -42,6 +42,9 @@ public class ContextualSearchFieldTrial {
static final String SIDE_SEARCH_PROVIDER_ICON_ENABLED =
"contextual_search_side_search_provider_icon_enabled";
+ static final String SELECTION_EXPANSION_DISABLED =
+ "contextual_search_selection_expansion_disabled";
+
private static final String CHINESE_LANGUAGE_CODE = "zh";
private static final String JAPANESE_LANGUAGE_CODE = "ja";
private static final String KOREAN_LANGUAGE_CODE = "ko";
@@ -250,6 +253,13 @@ public class ContextualSearchFieldTrial {
return getBooleanParam(SIDE_SEARCH_PROVIDER_ICON_ENABLED);
}
+ /**
+ * @return Whether the base page selection expansion after server response is disabled.
+ */
+ public static boolean isSelectionExpansionDisabled() {
+ return getBooleanParam(SELECTION_EXPANSION_DISABLED);
+ }
+
// --------------------------------------------------------------------------------------------
// Helpers.
// --------------------------------------------------------------------------------------------
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698