chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java - Issue 1230933005: Add a finch flag to disable ContextualSearch selection expansion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

Issue 1230933005: Add a finch flag to disable ContextualSearch selection expansion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add JavaDoc Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

index 460fe41aa06d3fd2b5e017c987934f35dba36003..176227acfa148a17b9dd473d5a8373e3d87ef43d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

@@ -294,6 +294,8 @@ public class ContextualSearchSelectionController {

* the search term.

void adjustSelection(int selectionStartAdjust, int selectionEndAdjust) {

+ if (ContextualSearchFieldTrial.isSelectionExpansionDisabled()) return;

// TODO(donnd): add code to verify that the selection is still valid before changing it.

// crbug.com/508354

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java ('k') | no next file » | no next file with comments »