Patch 3.1: Refactored spellcheck_message_filter to be generic

chrome/common/BUILD.gn

Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index c96180355c949b3656a887ff43acab3e4bd6237b..3f21182fce844b3fe837aed44309fc7a9dfb4a79 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -191,7 +191,6 @@ static_library("common") {
       "chrome_version_info_posix.cc",
       "icon_with_badge_image_source.cc",
       "media_galleries/metadata_types.h",
-      "spellcheck_common.cc",

[please use gerrit instead, 2015/07/10 18:35:43]

I did not find where this is used on Android in this patch. Please point it out,
if it's used. 

Otherwise, let's not add this file to Android build until it's needed.

[dylanking, 2015/07/11 01:46:24]

I was wondering why I took this out in the first place as well, until I ran some
trybots that failed to link:

FAILED: ........
../../chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc:301: error:
undefined reference to
'chrome::spellcheck_common::GetVersionedFileName(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::FilePath
const&)'
../../chrome/browser/spellchecker/spellcheck_service.cc:305: error: undefined
reference to
'chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >*, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)'
../../chrome/browser/spellchecker/spellcheck_service.cc:71: error: undefined
reference to
'chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >*, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)'
../../chrome/browser/spellchecker/spellcheck_service.cc:83: error: undefined
reference to 'chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()'
../../chrome/browser/spellchecker/spelling_service_client.cc:125: error:
undefined reference to
'chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()'
collect2: error: ld returned 1 exit status


FAILED: ........
../../chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc:301: error:
undefined reference to
'chrome::spellcheck_common::GetVersionedFileName(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::FilePath
const&)'
../../chrome/browser/spellchecker/spellcheck_service.cc:305: error: undefined
reference to
'chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >*, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)'
../../chrome/browser/spellchecker/spellcheck_service.cc:71: error: undefined
reference to
'chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >*, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)'
../../chrome/browser/spellchecker/spellcheck_service.cc:83: error: undefined
reference to 'chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()'
../../chrome/browser/spellchecker/spelling_service_client.cc:125: error:
undefined reference to
'chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.


I think we should keep spellcheck_common.cc in the build due to this.

     ]
   } else {
     # Non-Android.