Patch 3.1: Refactored spellcheck_message_filter to be generic

chrome/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//tools/grit/grit_rule.gni")
 import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni")
 
 gypi_values = exec_script("//build/gypi_to_gn.py",
                           [ rebase_path("../chrome_common.gypi") ],
                           "scope",
@@ skipping 173 matching lines @@
       "local_discovery/service_discovery_client_impl.h",
     ]
   }
 
   if (is_android) {
     sources -= [
       "badge_util.cc",
       "chrome_version_info_posix.cc",
       "icon_with_badge_image_source.cc",
       "media_galleries/metadata_types.h",
-      "spellcheck_common.cc",

[please use gerrit instead, 2015/07/10 18:35:43]

I did not find where this is used on Android in this patch. Please point it out,
if it's used. 

Otherwise, let's not add this file to Android build until it's needed.

[dylanking, 2015/07/11 01:46:24]

I was wondering why I took this out in the first place as well, until I ran some
trybots that failed to link:

FAILED: ........
../../chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc:301: error:
undefined reference to
'chrome::spellcheck_common::GetVersionedFileName(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::FilePath
const&)'
../../chrome/browser/spellchecker/spellcheck_service.cc:305: error: undefined
reference to
'chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >*, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)'
../../chrome/browser/spellchecker/spellcheck_service.cc:71: error: undefined
reference to
'chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >*, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)'
../../chrome/browser/spellchecker/spellcheck_service.cc:83: error: undefined
reference to 'chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()'
../../chrome/browser/spellchecker/spelling_service_client.cc:125: error:
undefined reference to
'chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()'
collect2: error: ld returned 1 exit status


FAILED: ........
../../chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc:301: error:
undefined reference to
'chrome::spellcheck_common::GetVersionedFileName(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::FilePath
const&)'
../../chrome/browser/spellchecker/spellcheck_service.cc:305: error: undefined
reference to
'chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >*, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)'
../../chrome/browser/spellchecker/spellcheck_service.cc:71: error: undefined
reference to
'chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >*, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> >*)'
../../chrome/browser/spellchecker/spellcheck_service.cc:83: error: undefined
reference to 'chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()'
../../chrome/browser/spellchecker/spelling_service_client.cc:125: error:
undefined reference to
'chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.


I think we should keep spellcheck_common.cc in the build due to this.

     ]
   } else {
     # Non-Android.
     sources +=
         rebase_path(gypi_values.chrome_common_importer_sources, ".", "//chrome")
   }
 
   if (is_chromeos) {
     sources -= [ "chrome_version_info_posix.cc" ]
   }
@@ skipping 151 matching lines @@
     ":constants",
     "//base",
   ]
 }
 
 mojom("mojo_bindings") {
   sources = [
     "resource_usage_reporter.mojom",
   ]
 }