Patch 3.1: Refactored spellcheck_message_filter to be generic

chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc

Index: chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc
diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc b/chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3923479b16e9098c7c37b6cd73ba45999d2ba5c4
--- /dev/null
+++ b/chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc
@@ -0,0 +1,69 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/spellchecker/spellcheck_message_filter_platform.h"
+
+#include "chrome/browser/spellchecker/spelling_service_client.h"

[please use gerrit instead, 2015/07/10 18:35:43]

This include is no longer necessary, because you decided to not create a
SpellingServiceClient.

[dylanking, 2015/07/11 01:46:23]

Done.

+#include "chrome/common/spellcheck_messages.h"
+#include "chrome/common/spellcheck_result.h"
+#include "content/public/browser/browser_context.h"

[please use gerrit instead, 2015/07/10 18:35:43]

Based on the code below, I think you should be including browser_thread.h
instead of browser_context.h.

[dylanking, 2015/07/11 01:46:23]

Done.

+
+using content::BrowserThread;
+
+SpellCheckMessageFilterPlatform::SpellCheckMessageFilterPlatform(
+    int render_process_id)
+    : BrowserMessageFilter(SpellCheckMsgStart),
+      render_process_id_(render_process_id) {
+}
+
+void SpellCheckMessageFilterPlatform::OverrideThreadForMessage(
+    const IPC::Message& message, BrowserThread::ID* thread) {
+}
+
+bool SpellCheckMessageFilterPlatform::OnMessageReceived(
+    const IPC::Message& message) {
+    return true; // to pass compiler checks

[please use gerrit instead, 2015/07/10 18:35:43]

No need for comment.

[dylanking, 2015/07/11 01:46:23]

Deleted.

+}
+
+// static
+void SpellCheckMessageFilterPlatform::CombineResults(
+    std::vector<SpellCheckResult>* remote_results,
+    const std::vector<SpellCheckResult>& local_results) {
+}
+
+SpellCheckMessageFilterPlatform::~SpellCheckMessageFilterPlatform() {}
+
+void SpellCheckMessageFilterPlatform::OnCheckSpelling(
+    const base::string16& word,
+    int route_id,
+    bool* correct) {
+}
+
+void SpellCheckMessageFilterPlatform::OnFillSuggestionList(
+    const base::string16& word,
+    std::vector<base::string16>* suggestions) {
+}
+
+void SpellCheckMessageFilterPlatform::OnShowSpellingPanel(bool show) {
+}
+
+void SpellCheckMessageFilterPlatform::OnUpdateSpellingPanelWithMisspelledWord(
+    const base::string16& word) {
+}
+
+void SpellCheckMessageFilterPlatform::OnRequestTextCheck(
+    int route_id,
+    int identifier,
+    const base::string16& text,
+    std::vector<SpellCheckMarker> markers) {
+}
+
+int SpellCheckMessageFilterPlatform::ToDocumentTag(int route_id) {
+    NOTREACHED();
+    return -1; // to pass compiler checks

[please use gerrit instead, 2015/07/10 18:35:43]

No need for comment.

[dylanking, 2015/07/11 01:46:23]

Deleted.

+}
+
+void SpellCheckMessageFilterPlatform::RetireDocumentTag(int route_id) {
+    NOTREACHED();
+}