Issue 1230603002: Revert of Add normal map sample

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230603002: Revert of Add normal map sample (Closed)

Created:
5 years, 5 months ago by robertphillips

Modified:
5 years, 5 months ago

Reviewers:
jvanverth1, bsalomon, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Add normal map sample (patchset #6 id:100001 of https://codereview.chromium.org/1212813009/) Reason for revert: Compilation failures: ../../../../../samplecode/SampleLighting.cpp:13:18: fatal error: SkGr.h: No such file or directory Original issue's description: > Add normal map sample > > This adds an example of an SkShader that does normal > mapping. It has a single directional light and an > ambient light. > > Committed: https://skia.googlesource.com/skia/+/8e0da72ba890de395c9946ec6639c9e1e7b16027 TBR=reed@google.com,bsalomon@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/426388eeb7fd5cb9226fb1d2067c04f3aba8d094

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -431 lines)			Patch
M	gyp/SampleApp.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	resources/brickwork-texture.jpg	View	Binary file		0 comments	Download
D	resources/brickwork_normal-map.jpg	View	Binary file		0 comments	Download
D	samplecode/SampleLighting.cpp	View	1 chunk	+0 lines, -430 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230603002/1

5 years, 5 months ago (2015-07-08 21:46:05 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-08 21:46:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/426388eeb7fd5cb9226fb1d2067c04f3aba8d094