Source/web/FrameLoaderClientImpl.h - Issue 122993002: Make calls to AtomicString(const String&) explicit in web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString type for frameName and target Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index 487a6bb55cf2a5b729a755e122f748cae674926c..12b3ec02b99c5a22ceaf1a41772ecc161c59770c 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -112,7 +112,7 @@ public:

virtual WTF::String userAgent(const WebCore::KURL&);

virtual WTF::String doNotTrackValue();

virtual void transitionToCommittedForNewPage();

- virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL&, const WTF::String& name, const WTF::String& referrer, WebCore::HTMLFrameOwnerElement*);

+ virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL&, const WTF::AtomicString& name, const WTF::String& referrer, WebCore::HTMLFrameOwnerElement*);

virtual PassRefPtr<WebCore::Widget> createPlugin(

const WebCore::IntSize&, WebCore::HTMLPlugInElement*, const WebCore::KURL&,

const Vector<WTF::String>&, const Vector<WTF::String>&,

« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »